I think Corinna has a good point that the knowledge is a burden. In a lot of ways Clark binds Lois to him by telling her. Once he tells her he always has to worry about how she takes it.
I will say he should tell her before proposing, but he should not tell her until he is ready to propose.
